Re: [PATCH v9 3/4] ASoC: tda998x: add a codec to the HDMI transmitter

From: Jean-Francois Moine
Date: Fri Jan 09 2015 - 06:13:03 EST


On Fri, 9 Jan 2015 12:24:12 +0200
Jyri Sarha <jsarha@xxxxxx> wrote:

> > select SND_SOC_TDA998X if SND_SOC
> >
> > should work in all cases.
> >
>
> I think that would still fail if DRM and TDA998x is built in and SND_SOC
> is built as modules. A request_module() call before
> tda9998x_codec_register() should help. Or could could write:
>
> select SND_SOC_TDA998X if (SND_SOC=DRM_I2C_NXP_TDA998X || SND_SOC=y)

request_module() is not needed because there are functions calls from
the transmitter to the codec.

With the simple "if SND_SOC", make menuconfig refuses to have TDA998x
built in and SND_SOC built as modules, as it should.

--
Ken ar c'hentaà | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/