Re: [PATCH] hwmon: (ina2xx) implement update_interval attribute for ina226

From: Guenter Roeck
Date: Thu Jan 08 2015 - 23:34:26 EST


On 01/08/2015 10:14 AM, Bartosz Golaszewski wrote:
2015-01-08 18:05 GMT+01:00 Guenter Roeck <linux@xxxxxxxxxxxx>:
What is the purpose of multiplying the calculated average by 2 ?

The comment above says:

+ /*
+ * Add bus and shunt voltage conversion times and multiple them
+ * by the averaging rate. Return the result in milliseconds.
+ */

Since both conversion times are the same and equal
INA226_CONV_TIME_DEFAULT I just multiplied it by 2 - I thought it was
clear enough. I'll fix that in the next iteration.


Sorry, still don't get it. I must be a bit slow today ;-)

Guenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/