Re: [wsa:i2c/quirks 10/11] drivers/i2c/busses/i2c-viperboard.c:357:27: sparse: symbol 'vprbrd_quirks' was not declared. Should it be static?

From: Wolfram Sang
Date: Thu Jan 08 2015 - 13:38:13 EST


On Fri, Jan 09, 2015 at 02:07:53AM +0800, kbuild test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux i2c/quirks
> head: b1d39af8ae21f4930854b0656aa83a83fd38049e
> commit: 5f7099010eda61b777ba84cf9b64dc8428846d25 [10/11] i2c: viperboard: make use of the new infrastructure for quirks
> reproduce:
> # apt-get install sparse
> git checkout 5f7099010eda61b777ba84cf9b64dc8428846d25
> make ARCH=x86_64 allmodconfig
> make C=1 CF=-D__CHECK_ENDIAN__
>
>
> sparse warnings: (new ones prefixed by >>)
>
> drivers/i2c/busses/i2c-viperboard.c:128:35: sparse: incorrect type in assignment (different base types)
> drivers/i2c/busses/i2c-viperboard.c:128:35: expected unsigned short [unsigned] [usertype] addr
> drivers/i2c/busses/i2c-viperboard.c:128:35: got restricted __le16 [usertype] <noident>
> drivers/i2c/busses/i2c-viperboard.c:201:34: sparse: incorrect type in assignment (different base types)
> drivers/i2c/busses/i2c-viperboard.c:201:34: expected unsigned short [unsigned] [usertype] tf1
> drivers/i2c/busses/i2c-viperboard.c:201:34: got restricted __le16 [usertype] <noident>
> drivers/i2c/busses/i2c-viperboard.c:202:34: sparse: incorrect type in assignment (different base types)
> drivers/i2c/busses/i2c-viperboard.c:202:34: expected unsigned short [unsigned] [usertype] tf2
> drivers/i2c/busses/i2c-viperboard.c:202:34: got restricted __le16 [usertype] <noident>
> drivers/i2c/busses/i2c-viperboard.c:237:35: sparse: incorrect type in assignment (different base types)
> drivers/i2c/busses/i2c-viperboard.c:237:35: expected unsigned short [unsigned] [usertype] addr
> drivers/i2c/busses/i2c-viperboard.c:237:35: got restricted __le16 [usertype] <noident>
> drivers/i2c/busses/i2c-viperboard.c:300:35: sparse: incorrect type in assignment (different base types)
> drivers/i2c/busses/i2c-viperboard.c:300:35: expected unsigned short [unsigned] [usertype] len
> drivers/i2c/busses/i2c-viperboard.c:300:35: got restricted __le16 [usertype] <noident>
> drivers/i2c/busses/i2c-viperboard.c:325:35: sparse: incorrect type in assignment (different base types)
> drivers/i2c/busses/i2c-viperboard.c:325:35: expected unsigned short [unsigned] [usertype] len
> drivers/i2c/busses/i2c-viperboard.c:325:35: got restricted __le16 [usertype] <noident>
> >> drivers/i2c/busses/i2c-viperboard.c:357:27: sparse: symbol 'vprbrd_quirks' was not declared. Should it be static?
>
> Please review and possibly fold the followup patch.

Development branch noise, please ignore.

Attachment: signature.asc
Description: Digital signature