Re: [PATCH] crypto: omap-des: fix BUG_ON condition

From: Herbert Xu
Date: Thu Jan 08 2015 - 05:48:44 EST


On Mon, Jan 05, 2015 at 10:23:10AM +0200, Asaf Vertz wrote:
> dd->total is unsigned so it won't do any good to check for negative value after subtracting
> instead of that we should check if the subtracted value is bigger than him
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Asaf Vertz <asaf.vertz@xxxxxxxxxxx>

Applied.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/