[PATCH] null_blk: fix blk_mq_init_queue() error handling

From: JÃrg Billeter
Date: Thu Jan 08 2015 - 05:04:45 EST


blk_mq_init_queue() returns ERR_PTR() on failure, not NULL.

Signed-off-by: JÃrg Billeter <j@xxxxxxxxx>
---
drivers/block/null_blk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/block/null_blk.c b/drivers/block/null_blk.c
index ae9f615..727309c 100644
--- a/drivers/block/null_blk.c
+++ b/drivers/block/null_blk.c
@@ -530,8 +530,8 @@ static int null_add_dev(void)
goto out_cleanup_queues;

nullb->q = blk_mq_init_queue(&nullb->tag_set);
- if (!nullb->q) {
- rv = -ENOMEM;
+ if (IS_ERR(nullb->q)) {
+ rv = PTR_ERR(nullb->q);
goto out_cleanup_tags;
}
} else if (queue_mode == NULL_Q_BIO) {
--
2.2.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/