Re: [PATCH V2 2/2] bfin_can: rewrite the driver to support the common

From: Tobias Klauser
Date: Thu Jan 08 2015 - 04:13:37 EST


On 2015-01-08 at 07:57:34 +0100, Aaron Wu <Aaron.wu@xxxxxxxxxx> wrote:
> Rewrite the driver to comply to common style with MMU
>
> Signed-off-by: Aaron Wu <Aaron.wu@xxxxxxxxxx>
> ---
> drivers/net/can/bfin_can.c | 21 ++++++++-------------
> 1 file changed, 8 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/net/can/bfin_can.c b/drivers/net/can/bfin_can.c
> index 0a5eff4..1d116a7 100644
> --- a/drivers/net/can/bfin_can.c
> +++ b/drivers/net/can/bfin_can.c
[...]
> @@ -617,9 +615,6 @@ static int bfin_can_remove(struct platform_device *pdev)
>
> unregister_candev(dev);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - release_mem_region(res->start, resource_size(res));
> -

struct resource *res will be unused in bfin_can_remove() after this
change, so it should be removed as well.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/