Re: [PATCH] ARM: imx_v6_v7_defconfig: Select CONFIG_FB_MXS

[Liu Ying]

2015-01-08 7:35 GMT+08:00 Fabio Estevam <festevam@xxxxxxxxx>:
> From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
>
> CONFIG_FB_MXS is the LCD driver for mx6solo-lite and mx6solox.
>
> Enable it by default.

I'm not sure if it is suitable to enable CONFIG_FB_MXS by default.
At least, I have no strong objections.

I am considering to add a LCDIF CRTC driver to the imx-drm framework
so that we may use the existing LDB drm driver to support the mx6solox
LVDS interface.

I see the i915 and omap2 fb drivers depend on !DRM_XXXX:

grep DRM_ drivers/video/fbdev/ -nr
drivers/video/fbdev/omap2/omapfb/Kconfig:3:        depends on FB &&
OMAP2_DSS && !DRM_OMAP
drivers/video/fbdev/Kconfig:1197:       depends on !DRM_I915

So, similarly, we'll probably have two LCDIF drivers and make the DRM
one enabled by default - finally, CONFIG_FB_MXS is disabled.

Another concern is the compatibility. Since both the framebuffer driver
and the imx-drm driver would export the framebuffer interface to the
user space, we'd better to keep the interface behavior the same.
Maybe, this is not a big problem, because we need to keep the compatibility
anyway...

Regards,
Liu Ying

>
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> ---
>  arch/arm/configs/imx_v6_v7_defconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
> index 9575af8..1f36977 100644
> --- a/arch/arm/configs/imx_v6_v7_defconfig
> +++ b/arch/arm/configs/imx_v6_v7_defconfig
> @@ -203,6 +203,7 @@ CONFIG_DRM_PANEL_SIMPLE=y
>  CONFIG_LCD_CLASS_DEVICE=y
>  CONFIG_LCD_L4F00242T03=y
>  CONFIG_LCD_PLATFORM=y
> +CONFIG_FB_MXS=y
>  CONFIG_BACKLIGHT_PWM=y
>  CONFIG_BACKLIGHT_GPIO=y
>  CONFIG_FRAMEBUFFER_CONSOLE=y
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
Best Regards,
Liu Ying
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/