Re: [PATCH -v2 1/5] oom: add helpers for setting and clearing TIF_MEMDIE

From: Michal Hocko
Date: Wed Jan 07 2015 - 13:23:45 EST


On Wed 07-01-15 12:57:31, Tejun Heo wrote:
> On Fri, Dec 05, 2014 at 05:41:43PM +0100, Michal Hocko wrote:
> > +/**
> > + * Unmarks the current task as OOM victim.
> > + */
> > +void unmark_tsk_oom_victim(void)
> > +{
> > + clear_thread_flag(TIF_MEMDIE);
> > +}
>
> This prolly should be unmark_current_oom_victim()?

OK.

> Also, can we
> please use full "task" at least in global symbols? I don't think tsk
> abbreviation is that popular in function names.

It is mimicking *_tsk_thread_flag() API.

--
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/