Re: [PATCH] spi: orion: Add multiple chip select support for Armada 370 and 375

From: Andrew Lunn
Date: Tue Jan 06 2015 - 16:49:56 EST


Hi Ken

> -static const struct orion_spi_dev armada_spi_dev_data = {
> +static const struct orion_spi_dev armada_370_spi_dev_data = {
> .typ = ARMADA_SPI,
> .min_divisor = 1,
> .max_divisor = 1920,
> .prescale_mask = ARMADA_SPI_CLK_PRESCALE_MASK,
> + .num_cs = 4,
> +};
> +
> +static const struct orion_spi_dev armada_375_spi_dev_data = {
> + .typ = ORION_SPI,
> + .min_divisor = 4,
> + .max_divisor = 30,
> + .prescale_mask = ORION_SPI_CLK_PRESCALE_MASK,
> + .num_cs = 3,
> };

Documentation/devicetree/bindings/spi/spi-bus.txt has the optional property:

- num-cs : total number of chipselects

Would it be better to use that?

Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/