Re: [PATCH 1/8] fs/9p: Deletion of unnecessary checks before the function call "p9_client_clunk"

From: Julia Lawall
Date: Mon Jan 05 2015 - 17:02:03 EST


> The error response is clear. Are any software developments efforts expected
> to clean-up the call stack for unwanted null pointers even more?

I found the original patch and looked at the call sites. None of them
calls dump_stack. The behavior is thus not the same. With your change,
something that was previously treated in an orderly manner will be
converted to something that looks like an oops. I assume that the cost of
the dump_stack will also be huge.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/