Re: [PATCH V3 0/4] Reducing parameters of alloc_pages* family of functions

[Vlastimil Babka]

On 01/05/2015 03:22 PM, Vlastimil Babka wrote:
> On 12/18/2014 10:26 PM, Andrew Morton wrote:
>> On Fri, 12 Dec 2014 17:13:21 +0100 Vlastimil Babka <vbabka@xxxxxxx> wrote:
>> 
>>> Vlastimil Babka (4):
>>>   mm: set page->pfmemalloc in prep_new_page()
>>>   mm, page_alloc: reduce number of alloc_pages* functions' parameters
>>>   mm: reduce try_to_compact_pages parameters
>>>   mm: microoptimize zonelist operations
>> 
>> That all looks pretty straightforward.  It would be nice to have a
>> summary of the code-size and stack-usage changes for the whole
>> patchset.
> 
> OK
> 
>> Can we move `struct alloc_context' into mm/internal.h?
> 
> Only if we moved also try_to_compact_pages() declaration from
> include/linux/compaction.h to mm/internal.h. I guess it's not a bad idea, as
> it's a MM-only function and mm/internal.h already contains compaction stuff.

Hm, nope. The !CONFIG_COMPACTION variant of try_to_compact_pages() is static
inline that returns COMPACT_CONTINUE, which is defined in compaction.h.
Another solution is to add a "forward" declaration (not actually followed later
by a full definition) of struct alloc_context into compaction.h. Seems to work
here, but I'm not sure if such thing is allowed?

>> I pity the poor schmuck who has to maintain this patchset for 2 months.
>> [2/4] already throws a large pile of rejects against page_alloc.c so
>> can you please refresh/retest/resend?
> 
> Right :)
> 
> Vlastimil
> 
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/