Re: [PATCH 6/7] perf tools: Append callchains only when requested

[Arnaldo Carvalho de Melo]

Em Sun, Jan 04, 2015 at 12:01:26AM +0900, Namhyung Kim escreveu:
> On Sat, Jan 3, 2015 at 11:25 AM, Arnaldo Carvalho de Melo
> <acme@xxxxxxxxxx> wrote:
> > Em Mon, Dec 22, 2014 at 01:44:14PM +0900, Namhyung Kim escreveu:
> >> The perf report --children can be called with callchain disabled so no
> >> need to append callchains.  Actually the root of callchain tree is not
> >> initialized properly in this case.

> >         I should have caught this using 'perf test', but it slipped
> > thru, please try running 'perf test cumulation', I noticed that it fails
> > and that if I revert this changeset it works again, can you please
> > check?
 
> This change should not affect the test result, but I guess the test
> somehow relied on the undefined behavior.  Actually I posted a patch
> to fix this problem.  So please take a look at the link below:
 
> https://lkml.org/lkml/2014/12/22/561

Ok, missed this one, will get it on perf/urgent and look if there are
patches pending merging in that pull req.

Thanks,

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/