Re: [PATCH] cleanup ti-soc-thermal

[Pavel Machek]

On Sat 2015-01-03 12:57:04, Nishanth Menon wrote:
> On 01/03/2015 12:51 PM, Pavel Machek wrote:
> >On Sat 2015-01-03 11:48:04, Nishanth Menon wrote:
> >>On 12:19-20150103, Pavel Machek wrote:
> >>>Simplify code by removing goto's where they point to simple return.
> >>>
> >>>Avoid confusing |= on error values.
> >>
> >>Please split these up into chunks of related changes. there is white
> >>space and quiet a few other changes all mixed in.
> >
> >Do you believe that the patch is too big to be understood? I don't
> >think it is.
> >
> >It is four screens, and it is pretty obvious it does not change any
> >code.
> 
> It basic patch generation stuff - where you are being nice to the reviewer.
> When you are doing functional changes, at least drop out or at the very
> least mention that there are white space changes in your patch
> submission.

Original submission said:

# Correct whitespace.

Some maintainers actually hate separate whitespace changes; talk to Al
Viro some day.

> I dont care too much to review stuff where I have to look at multiple
> changes in a single patch - trivial or not. Sorry.. just a waste of my time.

If 4 screens of trivial changes are too much for you, don't review
trivial patches, then. It is not your job.

Best regards,
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/