Re: [Xen-devel] xen/x86: properly retrieve NMI reason

From: Jan Beulich
Date: Fri Jan 02 2015 - 10:55:22 EST


>>> David Vrabel <david.vrabel@xxxxxxxxxx> 12/23/14 12:01 PM >>>
>On 19/12/14 16:16, Jan Beulich wrote:
>> Using the native code here can't work properly, as the hypervisor would
>> normally have cleared the two reason bits by the time Dom0 gets to see
>> the NMI (if passed to it at all). There's a shared info field for this,
>> and there's an existing hook to use - just fit the two together. Note
>> that the hook can (and should) be used irrespective of whether being in
>> Dom0, as accessing port 0x61 in a DomU would be even worse, while the
>> shared info field would just hold zero all the time.
>
>What's the user visible impact of this fix?

Depends on what "user visible" is: It ought to prevent "Dazed and confused..."
messages when not really applicable, and allow to get forwarded particularly
SERR ones to APEI (GHES) code instead. I can't say I've seen this work in
practice, as I lack ways to force SERR on otherwise well behaving hardware,
but code inspection shows that the way it is now it can't work as intended.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/