Re: [PATCH v7 2/4] fpga manager: add sysfs interface document

[Pantelis Antoniou]

Hi Pavel,

> On Jan 2, 2015, at 07:12 , Pavel Machek <pavel@xxxxxxx> wrote:
> 
> 
>> +What:		/sys/class/fpga_manager/<fpga>/firmware
>> +Date:		October 2014
>> +KernelVersion:	3.18
>> +Contact:	Alan Tull <atull@xxxxxxxxxxxxxxxxxxxxx>
>> +Description:	Name of the FPGA image file to load using firmware class.
> 
> This is wrong interface, right? The only use of this string is to pass
> it to udev. We should simply pass "fpga-0" as a firware name, and let
> udev figure it out, no need to to prepare name in separate component,
> then pass it to kernel, which passes it back to udev.
> 

No. No dependencies on udev please. This should hook directly to the firmware
loader interface which does not rely on userspace at all.

>> +What:		/sys/class/fpga_manager/<fpga>/reset
>> +Date:		October 2014
>> +KernelVersion:	3.18
>> +Contact:	Alan Tull <atull@xxxxxxxxxxxxxxxxxxxxx>
>> +Description:	Write 1 to reset the FPGA
> 
> Does 0 need to be written there to pull the fpga out of reset? Is this
> a suitable interface?
> 
> 								Pavel
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Regards

â Pantelis

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/