[PATCH 0/3 RFC] Coccinelle: completion API checking

From: Nicholas Mc Guire
Date: Fri Jan 02 2015 - 05:04:33 EST



This little set of semantic patches is for partially checking the
completion API. It seems to be working correctly and has not yet
produced any false-positive.

The cases being detected are:

1/3 - duplicate init_completions.
2/3 - incorrect static initialization of completion on stack.
3/3 - re-initialization of completion with init_completion() rather
than reinit_completion().

semantic patch findings files confirmed
duplicate_init_completion.cocci 2 2 2
false_declare_completion.cocci 6 5 3
false_init_compltion.cocci 9 6 5

Note: false_declare_completion.cocci runs extremely slow on my system
roughly a factor 10 slower than the other two - not clear why.

All findings have been submitted based on these scripts. Some have
not yet been confirmed.

Note sure if it makes sense putting this type of API misuse cleanup
into mainline given the relatively small number of findings.

patch is against linux-next 3.19.0-rc1 (-next-20141226)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/