RE: [PATCH 5/8] iio: core: Introduce IIO_CHAN_INFO_CALIBGENDER

From: Tirdea, Irina
Date: Mon Dec 29 2014 - 14:59:36 EST




> -----Original Message-----
> From: Jonathan Cameron [mailto:jic23@xxxxxxxxxx]
> Sent: 26 December, 2014 15:30
> To: Tirdea, Irina; linux-iio@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx; Dogaru, Vlad; Baluta, Daniel; Hartmut Knaack; Lars-Peter Clausen; Peter Meerwald
> Subject: Re: [PATCH 5/8] iio: core: Introduce IIO_CHAN_INFO_CALIBGENDER
>
> On 19/12/14 22:57, Irina Tirdea wrote:
> > Some devices need the gender of the user to compute various
> > parameters. One of this devices is Freescale's MMA9553L
> > (http://www.freescale.com/files/sensors/doc/ref_manual/MMA9553LSWRM.pdf)
> > that needs the gender of the user to compute distance, speed and activity type.
> >
> > Signed-off-by: Irina Tirdea <irina.tirdea@xxxxxxxxx>
>
> > ---
> > Documentation/ABI/testing/sysfs-bus-iio | 8 ++++++++
> > drivers/iio/industrialio-core.c | 1 +
> > include/linux/iio/iio.h | 1 +
> > 3 files changed, 10 insertions(+)
> >
> > diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> > index e480175..3b68c2d 100644
> > --- a/Documentation/ABI/testing/sysfs-bus-iio
> > +++ b/Documentation/ABI/testing/sysfs-bus-iio
> > @@ -343,6 +343,14 @@ Description:
> > production inaccuracies). If shared across all channels,
> > <type>_calibscale is used.
> >
> > +What: /sys/bus/iio/devices/iio:deviceX/in_steps_calibgender
> > +KernelVersion: 3.19
> > +Contact: linux-iio@xxxxxxxxxxxxxxx
> > +Description:
> > + Gender of the user: 0 for female and 1 for male. It is needed
> > + by some pedometers to compute the stride length, distance,
> > + speed and activity type.
> This will have to go through the extended attribute enum interface. No magic
> numbers in the interface please.

Sure, I will change this in next version.

Thanks for the reviews, Jonathan!

Irina

> > +
> > What: /sys/bus/iio/devices/iio:deviceX/in_steps_calibheight
> > KernelVersion: 3.19
> > Contact: linux-iio@xxxxxxxxxxxxxxx
> > diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> > index 4c435c8..93a39f9 100644
> > --- a/drivers/iio/industrialio-core.c
> > +++ b/drivers/iio/industrialio-core.c
> > @@ -125,6 +125,7 @@ static const char * const iio_chan_info_postfix[] = {
> > [IIO_CHAN_INFO_ENABLE] = "en",
> > [IIO_CHAN_INFO_CALIBHEIGHT] = "calibheight",
> > [IIO_CHAN_INFO_CALIBWEIGHT] = "calibweight",
> > + [IIO_CHAN_INFO_CALIBGENDER] = "calibgender",
> > };
> >
> > /**
> > diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> > index 752a929..63dac0f 100644
> > --- a/include/linux/iio/iio.h
> > +++ b/include/linux/iio/iio.h
> > @@ -41,6 +41,7 @@ enum iio_chan_info_enum {
> > IIO_CHAN_INFO_ENABLE,
> > IIO_CHAN_INFO_CALIBHEIGHT,
> > IIO_CHAN_INFO_CALIBWEIGHT,
> > + IIO_CHAN_INFO_CALIBGENDER,
> > };
> >
> > enum iio_shared_by {
> >

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/