Re: [PATCH 0/3] clk: samsung: Use samsung_cmu_register_one() to simplify code

From: Sylwester Nawrocki
Date: Tue Dec 23 2014 - 08:41:51 EST


Hi Chanwoo,

On 23/12/14 08:40, Chanwoo Choi wrote:
> This patch-set uses the samsung_cmu_register_one() function to simplify the
> clock driver for Exynos3250/Exynos4415 SoC and change return value of
> samsung_cmu_register_one() because some clock driver may need the instance
> of samsung_clk_provider structure.
>
> Chanwoo Choi (3):
> clk: samsung: Changes the return value of samsung_cmu_register_one()
> clk: samsung: exynos3250: Use samsung_cmu_register_one() to simplify code
> clk: samsung: exynos4415: Use samsung_cmu_register_one() to simplify code
>
> drivers/clk/samsung/clk-exynos3250.c | 217 ++++++++---------------------------
> drivers/clk/samsung/clk-exynos4415.c | 216 ++++++++--------------------------
> drivers/clk/samsung/clk.c | 13 ++-
> drivers/clk/samsung/clk.h | 3 +-
> 4 files changed, 107 insertions(+), 342 deletions(-)

Thanks for the cleanup, I've queued that for 3.20. And fixed a minor
checkpatch warning when applying:

ERROR: "foo* __init bar" should be "foo * __init bar"
#29: FILE: drivers/clk/samsung/clk.c:377:
+struct samsung_clk_provider* __init samsung_cmu_register_one(

total: 1 errors, 0 warnings, 42 lines checked

0001-clk-samsung-Changes-the-return-value-of-samsung_cmu_.patch has style
problems, please review.

--
Thanks,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/