Re: [PATCH] tools: lib: traceevent: event-parse.c: Remove some unused functions

[Rickard Strandqvist]

2014-12-22 16:07 GMT+01:00 Jiri Olsa <jolsa@xxxxxxxxxx>:
> On Mon, Dec 22, 2014 at 12:52:10PM -0200, Arnaldo Carvalho de Melo wrote:
>> Em Sat, Dec 20, 2014 at 01:45:41PM +0100, Rickard Strandqvist escreveu:
>> > Removes some functions that are not used anywhere:
>> > pevent_get_any_field_val() pevent_get_common_field_val() pevent_event_fields() pevent_event_common_fields() pevent_list_events() pevent_print_event() pevent_data_event_from_type() pevent_register_trace_clock() pevent_pid_is_registered()
>> >
>> > This was partially found by using a static code analysis program called cppcheck.
>>
>> Steven, Namhyung, Jiri:
>>
>> Are you ok with me applying this patch? I'm all for it, dead code better
>> be removed, but I don't know what are your plans wrt synchronization
>> with the trace-cmd repo.
>
> I'm not aware about more porting from traceevent lib, but I'm
> guessing there's still lot of things missing..?
>
> However, if we go with the removal, this patch has same
> issue as the other one.. missing removal of functions
> used only in removed code:
>
>
>   CC FPIC  event-parse.o
> /home/jolsa/kernel.org/linux-perf/tools/lib/traceevent/event-parse.c:4597:13: warning: âis_timestamp_in_usâ defined but not used [-Wunused-function]
>  static bool is_timestamp_in_us(char *trace_clock, bool use_trace_clock)
>              ^
> /home/jolsa/kernel.org/linux-perf/tools/lib/traceevent/event-parse.c:4624:12: warning: âevents_name_cmpâ defined but not used [-Wunused-function]
>  static int events_name_cmp(const void *a, const void *b)
>             ^
> /home/jolsa/kernel.org/linux-perf/tools/lib/traceevent/event-parse.c:4641:12: warning: âevents_system_cmpâ defined but not used [-Wunused-function]
>  static int events_system_cmp(const void *a, const void *b)
>             ^
> /home/jolsa/kernel.org/linux-perf/tools/lib/traceevent/event-parse.c:4659:1: warning: âget_event_fieldsâ defined but not used [-Wunused-function]
>  get_event_fields(const char *type, const char *name,
>  ^
>   CC FPIC  event-plugin.o
>
>
> thanks,
> jirka

Hi

Sounds good!
I'll check on the warnings to.

Kind regards
Rickard Strandqvist
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/