Re: [PATCH v3 5/5] ASoC: dwc: Add documentation for I2S DT

From: Mark Brown
Date: Mon Dec 22 2014 - 11:52:53 EST


On Mon, Dec 22, 2014 at 03:51:38PM +0000, Andrew Jackson wrote:
> On 12/22/14 14:26, Mark Brown wrote:

> > This is a name based lookup of clocks but the code doesn't use
> > apb_pclk at all; it needs to or the binding needs to say that apb_pclk
> > must be the first listed clock (which would not be good).

> I can remove apb_pclk: I was modelling the device tree entry on
> various PLxxx examples (c.f. amba-pl011) which also reference an AMBA clock
> but don't use it. (The effect being to document what clock the block is
> driven by.)

With the AMBA devices the AMBA core manages the bus clock for the
drivers IIRC.

Attachment: signature.asc
Description: Digital signature