Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init

[Oded Gabbay]

On 12/20/2014 11:25 PM, Greg KH wrote:
> On Sat, Dec 20, 2014 at 10:46:12PM +0200, Oded Gabbay wrote:
> > When amdkfd and radeon are compiled inside the kernel image (not as modules),
> > radeon will load before amdkfd and will set *kfd2kgd to its interface
> > structure. Therefore, we must not set *kfd2kgd to NULL when amdkfd is loaded
> > because it will override radeon's initialization and cause kernel BUG.
> >
> > Signed-off-by: Oded Gabbay <oded.gabbay@xxxxxxx>
> > ---
> >   drivers/gpu/drm/amd/amdkfd/kfd_module.c | 5 ++---
> >   1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_module.c b/drivers/gpu/drm/amd/amdkfd/kfd_module.c
> > index 95d5af1..236562f 100644
> > --- a/drivers/gpu/drm/amd/amdkfd/kfd_module.c
> > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_module.c
> > @@ -34,7 +34,7 @@
> >   #define KFD_DRIVER_MINOR	7
> >   #define KFD_DRIVER_PATCHLEVEL	0
> >
> > -const struct kfd2kgd_calls *kfd2kgd;
> > +const struct kfd2kgd_calls *kfd2kgd = NULL;
>
> This change does nothing, that is what the original code did already.
>
> thanks,
>
> greg k-h
Yeah. Sorry, I will remove it.
	
	Oded
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/