Re: [PATCH] kernel: removed unnecessary initialization of static variable

From: Jeremiah Mahler
Date: Sun Dec 21 2014 - 02:22:21 EST


Gangadhar,

On Sun, Dec 21, 2014 at 09:09:05AM +0530, Gangadhar Vukkesala wrote:
> Removed unnecessary initialization of static variable "zero" to 0
> in pid_namespace.c as default value of static variable is 0.
> This issue was found when running checkpatch.pl script on pid_namespace.c.
>
> Signed-off-by: Gangadhar Vukkesala <gangs.freelancer@xxxxxxxxx>
> ---
> kernel/pid_namespace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/pid_namespace.c b/kernel/pid_namespace.c
> index a65ba13..f21eb3f 100644
> --- a/kernel/pid_namespace.c
> +++ b/kernel/pid_namespace.c
> @@ -290,7 +290,7 @@ static int pid_ns_ctl_handler(struct ctl_table *table, int write,
> }
>
> extern int pid_max;
> -static int zero = 0;
> +static int zero;
> static struct ctl_table pid_ns_ctl_table[] = {
> {
> .procname = "ns_last_pid",
> --
> Gangadhar Vukkesala
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

Looks good.

Reviewed-by: Jeremiah Mahler <jmmahler@xxxxxxxxx>

--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/