Re: [PATCH] Staging: comedi: fix redundant parens in return in amplc_dio200_common.c

From: Jeremiah Mahler
Date: Thu Dec 18 2014 - 17:45:13 EST


Aapo,

On Thu, Dec 18, 2014 at 05:32:52PM +0200, Aapo Vienamo wrote:
> This patch fixes a coding style issue found by the checkpatch.pl tool in
> amplc_dio200_common.c by removing the unnecessary parentheses around the
> expression in a return statement.
>
> Signed-off-by: Aapo Vienamo <aapo.vienamo@xxxxxx>
> ---
> drivers/staging/comedi/drivers/amplc_dio200_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/amplc_dio200_common.c b/drivers/staging/comedi/drivers/amplc_dio200_common.c
> index 26aad70..6eadbbe 100644
> --- a/drivers/staging/comedi/drivers/amplc_dio200_common.c
> +++ b/drivers/staging/comedi/drivers/amplc_dio200_common.c
> @@ -340,7 +340,7 @@ static int dio200_handle_read_intr(struct comedi_device *dev,
>
> comedi_handle_events(dev, s);
>
> - return (triggered != 0);
> + return triggered != 0;
> }
>
[...]

When I run checkpatch.pl it doesn't find any errors and the parenthesis
haven't been removed. How are you running checkpatch.pl? Are you using
any extra options?

--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/