Re: [PATCH v4 1/3] ARM: at91: Add Special Function Registers binding documentation

From: Nicolas Ferre
Date: Thu Dec 18 2014 - 08:39:51 EST


Le 18/12/2014 10:45, Alexandre Belloni a écrit :
> The special function registers gather some registers that allow to tweak
> features provided by IPs controlled through another register range.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>
> Acked-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>

It seems okay. For the whole series:
Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>

And stacked on top of at91-3.20-dt.

But I will modify the size of the reg property to 0x60.

Thanks, bye.

> ---
> Changes in v4:
> - corrected the chip list
>
> Documentation/devicetree/bindings/arm/atmel-at91.txt | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.txt b/Documentation/devicetree/bindings/arm/atmel-at91.txt
> index 562cda9d86d9..f39e312531f0 100644
> --- a/Documentation/devicetree/bindings/arm/atmel-at91.txt
> +++ b/Documentation/devicetree/bindings/arm/atmel-at91.txt
> @@ -136,3 +136,20 @@ Example:
> compatible = "atmel,at91sam9260-rstc";
> reg = <0xfffffd00 0x10>;
> };
> +
> +Special Function Registers (SFR)
> +
> +Special Function Registers (SFR) manage specific aspects of the integrated
> +memory, bridge implementations, processor and other functionality not controlled
> +elsewhere.
> +
> +required properties:
> +- compatible: Should be "atmel,<chip>-sfr", "syscon".
> + <chip> can be "sama5d3" or "sama5d4".
> +- reg: Should contain registers location and length
> +
> + sfr@f0038000 {
> + compatible = "atmel,sama5d3-sfr", "syscon";
> + reg = <0xf0038000 0x4000>;
> + };
> +
>


--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/