Re: [PATCH] Fixed TPACKET V3 to signal poll when block is closed rather than for every packet

From: David Miller
Date: Wed Dec 17 2014 - 23:37:36 EST


From: Dan Collins <dan@xxxxxxxxxxxxxx>
Date: Thu, 18 Dec 2014 12:36:56 +1300


> Make TPACKET_V3 signal poll when block is closed rather than for every packet. Side effect is that poll will be signaled when block retire timer expires which didn't previously happen. Issue was visible when sending packets at a very low frequency such that all blocks are retired before packets are received by TPACKET_V3. This caused avoidable packet loss. The fix ensures that the signal is sent when blocks are closed which covers the normal path where the block is filled as well as the path where the timer expires. The case where a block is filled without moving to the next block (ie. all blocks are full) will still cause poll to be signaled.

Please format your commit messages to 80 column ascii formatted text.

> Signed-off-by: Dan Collins &lt;dan@xxxxxxxxxxxxxx&gt;

You need real "<" and ">" characters here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/