Re: How to fix CHECK warning: testing a 'safe expression' ?

From: Christopher Li
Date: Wed Dec 17 2014 - 21:39:15 EST


On Thu, Dec 18, 2014 at 6:37 AM, Murali Karicheri <m-karicheri2@xxxxxx> wrote:
> if (!ks_pcie) {
> dev_err(dev, "no memory for keystone pcie\n");
> return -ENOMEM;
> }
> pp = &ks_pcie->pp;
>
> /* initialize SerDes Phy if present */
> phy = devm_phy_get(dev, "pcie-phy");
> ===> if (!IS_ERR_OR_NULL(phy)) {
> ret = phy_init(phy);
> if (ret < 0)
> return ret;
>

Hi,

Do you have a smaller stand alone test case which I can reproduce with sparse?

Thanks

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/