Re: frequent lockups in 3.18rc4

From: Al Viro
Date: Sat Dec 13 2014 - 18:39:34 EST


On Sat, Dec 13, 2014 at 02:59:43PM -0800, Linus Torvalds wrote:
> Side note: I think I've found a real potential lockup bug in
> fs/namespace.c, but afaik it could only trigger with the RT patches.

> Except it won't with the RT patches, I guess. So it looks like you could have:\
>
> - mnt_make_readonly() sets that bit
> - gets preempted with the RT patches
> - we run mnt_want_write() on all CPU's, which disables preemption and
> waits for the bit to be cleared
> - nothing happens.
>
> This is clearly not what happens in your lockup, but it does seem to
> be a potential issue for the RT kernel.
>
> Added Al and Thomas to the cc, for fs/namespace.c and RT kernel
> respectively. Maybe the RT patches already fix this, I didn't actually
> check.

I agree that it's a thing to keep in mind on the RT side of things, but
IMO it belongs in RT patches...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/