Re: [PATCH] staging: goldfish: Fix minor coding style

[One Thousand Gnomes]

On Sat, 13 Dec 2014 17:29:26 +0100
Loic Pefferkorn <loic@xxxxxxxx> wrote:

> Hello,
> 
> The convention for checking for NULL pointers is !ptr and not ptr == NULL.
> This patch fixes such occurences in goldfish driver, it applies against next-20141212
> 
> 
> Signed-off-by: Loic Pefferkorn <loic@xxxxxxxx>

Pointless churn. It makes it less readable if anything, and it removes
the type safety as you are now checking against 0 not (void *)0

NAK

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/