Re: Re: [PATCH] USB: serial: add nt124 usb to serial driver

[Karl Palsson]

Johan Hovold <johan@xxxxxxxxxx> wrote:
> On Mon, Dec 08, 2014 at 05:24:17PM -0600, George McCollister wrote:

> > +	newline.bParityType = termios->c_cflag & PARENB ?
> > +				(termios->c_cflag & PARODD ? 1 : 2) +
> > +				(termios->c_cflag & CMSPAR ? 2 : 0) : 0;
> 
> This hardly readable. Don't use ?:
> 

There's also C_PARENB(tty),  C_PARODD(tty), and C_CMSPAR(tty) macros
available, in addition to the others that Johan pointed out.

Sincerely,
Karl P