Re: [PATCH net-next] net: sock: fix access via invalid file descriptor

From: David Miller
Date: Wed Dec 10 2014 - 23:34:49 EST


From: Alexei Starovoitov <ast@xxxxxxxxxxxx>
Date: Wed, 10 Dec 2014 20:14:55 -0800

> 0day robot reported the following crash:
> [ 21.233581] BUG: unable to handle kernel NULL pointer dereference at 0000000000000007
> [ 21.234709] IP: [<ffffffff8156ebda>] sk_attach_bpf+0x39/0xc2
>
> It's due to bpf_prog_get() returning ERR_PTR.
> Check it properly.
>
> Reported-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> Fixes: 89aa075832b0 ("net: sock: allow eBPF programs to be attached to sockets")
> Signed-off-by: Alexei Starovoitov <ast@xxxxxxxxxxxx>
> ---
> Silly mistake. I was sure I've checked this error path. Apparently not :(

Applied, thanks Alexei.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/