Re: [PATCH 7/20] drm/i915: fix misspelling of current function in string

From: Jani Nikula
Date: Mon Dec 08 2014 - 05:24:56 EST


On Sun, 07 Dec 2014, Julia Lawall <Julia.Lawall@xxxxxxx> wrote:
> Replace a misspelled function name by %s and then __func__.
>
> This was done using Coccinelle, including the use of Levenshtein distance,
> as proposed by Rasmus Villemoes.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>
>
> ---
> The semantic patch is difficult to summarize, but is available in the cover
> letter of this patch series.
>
> The message is sort of ambiguous, but I assume that it is intended to refer
> to the function in which the problem is detected.

Hmm, DRM_DEBUG prints __func__ too.

Jani.

>
> drivers/gpu/drm/i915/i915_gem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index d2ba315..fa21d1c 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -4335,7 +4335,7 @@ i915_gem_unpin_ioctl(struct drm_device *dev, void *data,
> }
>
> if (obj->pin_filp != file) {
> - DRM_DEBUG("Not pinned by caller in i915_gem_pin_ioctl(): %d\n",
> + DRM_DEBUG("Not pinned by caller in %s(): %d\n", __func__,
> args->handle);
> ret = -EINVAL;
> goto out;
>

--
Jani Nikula, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/