[PATCH 1/1] ACPI: Deletion of an unnecessary check before the function call "pci_dev_put"

From: SF Markus Elfring
Date: Sun Nov 30 2014 - 05:08:58 EST


From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 30 Nov 2014 10:59:10 +0100

The pci_dev_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
---
drivers/acpi/ioapic.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/acpi/ioapic.c b/drivers/acpi/ioapic.c
index 9a631a6..35963d3 100644
--- a/drivers/acpi/ioapic.c
+++ b/drivers/acpi/ioapic.c
@@ -185,8 +185,7 @@ exit_disable:
if (dev)
pci_disable_device(dev);
exit_put:
- if (dev)
- pci_dev_put(dev);
+ pci_dev_put(dev);
exit_free:
kfree(ioapic);
exit:
--
2.1.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/