Re: [PATCH 2/2] mmc: rtsx: add support for sdio card

From: 敬锐
Date: Thu Nov 27 2014 - 20:58:19 EST



On 11/27/2014 11:43 PM, Dan Carpenter wrote:
>> + int stat_idx = sd_status_index(rsp_type);
> I have always hated this terrible pointer math. 5 is relative to
> pcr->host_cmds_ptr + 1. It's a mess...
5 mean CRC7 offset of Response R1, see SD spec V3.01 Page 82.
4.9.1 R1 (normal response command).

And we have to +1 to skip unused/undefined data.