Re: [PATCH 1/4] spi: Add new driver for STMicroelectronics' SPI Controller

From: Mark Brown
Date: Thu Nov 27 2014 - 11:27:13 EST


On Thu, Nov 27, 2014 at 03:05:08PM +0000, Lee Jones wrote:

> > > + /* Set SSC_CTL to 16 bits-per-word */
> > > + ctl = readl_relaxed(spi_st->base + SSC_CTL);
> > > + writel_relaxed((ctl | 0xf), spi_st->base + SSC_CTL);

> > > + readl_relaxed(spi_st->base + SSC_RBUF);

> > No byte swapping issues here?

> I think this implementation has been pretty heavily tested. What
> should I be looking out for?

The bytes on the bus should be in exactly the same order as in memory if
the word size is 8, SPI words should be big endian normally.

Attachment: signature.asc
Description: Digital signature