Re: [PATCH] staging: media: lirc: lirc_zilog.c: fix quoted strings split across lines

From: Luis de Bethencourt
Date: Wed Nov 26 2014 - 19:39:41 EST


On Wed, Nov 26, 2014 at 08:05:55AM -0800, Joe Perches wrote:
> On Wed, 2014-11-26 at 15:42 +0000, Luis de Bethencourt wrote:
> > On 26 November 2014 at 01:49, Joe Perches <joe@xxxxxxxxxxx> wrote:
> []
> > > There is a script I posted a while back that
> > > groups various checkpatch "types" together and
> > > makes it a bit easier to do cleanup style
> > > patches.
> > >
> > > https://lkml.org/lkml/2014/7/11/794
> > That is useful! I just run it on staging/octeon/ and it wrote two patches.
> > Will submit them in a minute.
>
> Please make sure and write better commit messages
> than the script produces.
>

Will do :)

> > > Using checkpatch to get familiar with kernel
> > > development is fine and all, but fixing actual
> > > defects and submitting new code is way more
> > > useful.
> []
> > I agree. I was just using checkpatch to learn about the development process.
> > How to create patches, submit patches, follow review, and such. Better to
> > do it
> > with small changes like this first.
>
> That's a good way to start.
>
> > Which makes me wonder. Is my patch accepted? Will it be merged? I can do the
> > proposed logging macro additions in a few days. Not sure yet how the final
> > step of the process when patches get accepted and merged works.
>
> You will generally get an email from a maintainer
> when patches are accepted/rejected or you get
> feedback asking for various changes.
>
> Greg KH does that for drivers/staging but not for
> drivers/staging/media. Mauro Carvalho Chehab does.
>
> These emails are not immediate. It can take 2 or 3
> weeks for a response. Sometimes longer, sometimes
> shorter, sometimes no response ever comes.
>

I understand. Busy people.

> After a month or so, if you get no response, maybe
> the maintainer never saw it. You should maybe
> expand the cc: list for the email.
>
> When the patch is more than a trivial style cleanup,
> Andrew Morton generally picks up orphan patches.
>
> For some subsystems, there are "tracking" mechanisms
> like patchwork:
>
> For instance, netdev (net/ and drivers/net/) uses:
> http://patchwork.ozlabs.org/project/netdev/list/
> and David Miller, the primary networking maintainer
> is very prompt about updating it.
>
> There's this list of patchwork entries, but maintainer
> activity of these lists vary:
>
> https://patchwork.kernel.org/
>

Very interesting.

I will follow the process through and learn on the way.

Thanks Joe!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/