Re: [RFC][PATCH 0/9 v2] ftrace/x86: Clean up of mcount.S code

From: Steven Rostedt
Date: Wed Nov 26 2014 - 18:13:36 EST


On Wed, 26 Nov 2014 23:05:48 +0100 (CET)
Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:

> On Tue, 25 Nov 2014, Steven Rostedt wrote:
> > Steven Rostedt (Red Hat) (9):
> > ftrace/x86: Have static tracing also use ftrace_caller_setup
> > ftrace/x86: Move MCOUNT_SAVE_FRAME out of header file
> > ftrace/x86: Rename MCOUNT_SAVE_FRAME and add more detailed comments
> > ftrace/x86: Have save_mcount_regs store RIP in %rdi for first parameter
> > ftrace/x86: Simplify save_mcount_regs on getting RIP
> > ftrace/x86: Add macro MCOUNT_REG_SIZE for amount of stack used to save mcount regs
> > ftrace/x86: Have save_mcount_regs macro also save stack frames if needed
> > ftrace/x86: Get rid of ftrace_caller_setup
> > ftrace/fgraph/x86: Have prepare_ftrace_return() take ip as first parameter
>
> I took the last remaining cells of my review damaged brain together to
> go through this with a fine comb. So far I could not find something,
> but I might have missed the obvious.
>
> Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>

Thanks!

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/