Re: [PATCH] fat: Fix oops on corrupted vfat fs

From: Andrew Morton
Date: Wed Nov 26 2014 - 17:28:13 EST


On Thu, 27 Nov 2014 00:31:28 +0900 OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx> wrote:

> a) don't bother with ->d_time for positives - we only check it for negatives
> anyway.
> b) make sure to set it at unlink and rmdir time - at *that* point soon-to-be
> negative dentry matches then-current directory contents
> c) don't go into renaming of old alias in vfat_lookup() unless it has
> the same parent (which it will, unless we are seeing corrupted image)
>
> Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx> # 3.17.x
> [Make change minimum, don't call d_move() for dir]
> Signed-off-by: OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>

It's unclear who did the "[Make change minimum.." alteration.

I do it this way:
[hirofumi@xxxxxxxxxxxxxxxxxx: make change minimum, don't call d_move() for dir]

Also, who was the primary author of this patch? It *looks* like it was
Al, unsure. If it was indeed Al then this can be communicated by
putting his From: line at the very top of the changelog body.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/