Re: perf/x86/intel/uncore: Add Haswell-EP uncore support

From: Andi Kleen
Date: Wed Nov 26 2014 - 09:14:27 EST


> I couldn't quickly decipher which MSRs we're writing to here in the SDM,
> but are these really 64-bit wide registers that need 32 bits always set to zero ?

Yes the filter MSRs are only 32bit.

> I'm wondering if these should be just wrmsr's instead of wrmsrl's.

Can we just shut up coverity please?

wrmsr() is stupid and error prone and should have never been added as an
interface.

-Andi
--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/