Re: [PATCH v4 13/42] virtio_blk: v1.0 support

From: Michael S. Tsirkin
Date: Tue Nov 25 2014 - 16:44:09 EST


On Tue, Nov 25, 2014 at 06:55:16PM +0100, Cornelia Huck wrote:
> On Tue, 25 Nov 2014 18:42:18 +0200
> "Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote:
>
> > Based on patch by Cornelia Huck.
> >
> > Note: for consistency, and to avoid sparse errors,
> > convert all fields, even those no longer in use
> > for virtio v1.0.
> >
> > Reviewed-by: Thomas Huth <thuth@xxxxxxxxxxxxxxxxxx>
> > Reviewed-by: David Hildenbrand <dahi@xxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Cornelia Huck <cornelia.huck@xxxxxxxxxx>
> > Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> > ---
> > include/uapi/linux/virtio_blk.h | 15 ++++-----
> > drivers/block/virtio_blk.c | 70 ++++++++++++++++++++++++-----------------
> > 2 files changed, 49 insertions(+), 36 deletions(-)
> >
>
> Is this sufficiently unchanged so that the original r-bs still hold?

You are right, I'm afraid I'll have to drop these.
Thomas, David, care to comment?
Even better - have the cycles to review the latest version?

--
MST
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/