Re: kernel-audit: Deletion of an unnecessary check before the function call "audit_log_end"

From: SF Markus Elfring
Date: Sun Nov 23 2014 - 08:25:13 EST


> Normally, tests only hurt readability if they cannot be false or cannot be true.
> Making a choice apparent when there really is a choice would seem
> to aid understanding.

I agree also to such facts.


> Program analysis tools can also potentially exploit this information,

The published semantic patch scripts correspond to this desire.


> which you are so systmatically removing.

I try to delete redundant checks in various function implementations as much
as possible.

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/