Re: [PATCH v13 5/9] arm: omap1: Migrate debug_ll macros to use 8250.S

From: Tony Lindgren
Date: Fri Nov 21 2014 - 18:40:21 EST


* Daniel Thompson <daniel.thompson@xxxxxxxxxx> [141117 06:53]:
> The omap1's debug-macro.S is similar to the generic 8250 code. Compared to
> the 8520 code the omap1 macro automatically determines what UART to use
> based on breadcrumbs left by the bootloader and automatically copes with
> the eccentric register layout on OMAP7XX.
>
> This patch drops both these features and relies instead on the generic
> 8250 macros:
>
> 1. Dropping support for the bootloader breadcrumbs is identical to the
> way the migration was handled for OMAP2 (see 808b7e07464d...).
>
> 2. Support for OMAP7XX still exists but it must be configured by hand
> (DEBUG_OMAP7XXUART1/2/3) rather than handled at runtime.
>
> Signed-off-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
> Cc: Russell King <linux@xxxxxxxxxxxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: Tony Lindgren <tony@xxxxxxxxxxx>
> Cc: Arnd Bergmann <arnd.bergmann@xxxxxxxxxx>
> Cc: linux-omap@xxxxxxxxxxxxxxx
> Tested-by: Aaro Koskinen <aaro.koskinen@xxxxxx>

Looks OK to me, probably best that these are queued all together so:

Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/