Re: [PATCH 3.14 102/122] mm + fs: prepare for non-page entries in page cache radix trees

From: Mel Gorman
Date: Thu Nov 20 2014 - 11:21:34 EST


On Thu, Nov 20, 2014 at 10:49:37AM -0500, Johannes Weiner wrote:
> On Wed, Nov 19, 2014 at 12:52:32PM -0800, Greg Kroah-Hartman wrote:
> > 3.14-stable review patch. If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Johannes Weiner <hannes@xxxxxxxxxxx>
> >
> > commit 0cd6144aadd2afd19d1aca880153530c52957604 upstream.
> >
> > shmem mappings already contain exceptional entries where swap slot
> > information is remembered.
> >
> > To be able to store eviction information for regular page cache, prepare
> > every site dealing with the radix trees directly to handle entries other
> > than pages.
>
> I don't see the rest of the thrash-detection patches in this series.
> Without anybody actually planting "entries other than pages" in the
> radix trees, why is this needed in -stable?

Patches later on in the stable series depended upon the code structure
introduced by this patch even though the thrash-detection stuff was not
backported. It could have been backported without it but then the
patches would look much different from their mainline equivalent.

--
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/