Re: [PATCH 3/3] mfd: cros_ec: Expose Chrome OS Lightbar to users

From: Javier Martinez Canillas
Date: Thu Nov 20 2014 - 07:00:53 EST


Hello Lee,

On 11/18/2014 03:22 PM, Lee Jones wrote:
>> ---
>> drivers/mfd/Makefile | 2 +-
>> drivers/mfd/cros_ec_dev.c | 2 +
>> drivers/mfd/cros_ec_dev.h | 3 +
>> drivers/mfd/cros_ec_lightbar.c | 347 +++++++++++++++++++++++++++++++++++++++++
>
> By the sounds of the description, it doesn't seem as though this
> driver lives in MFD. I suggest another home, such as drivers/led.
>

You are right. As I said in the other email, I'll move it to
drivers/platform/chrome/ which seems like a more suitable place.

Thanks a lot for your feedback.

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/