Re: [PATCHv2 1/1] thermal: of: improve of-thermal sensor registration API

From: Eduardo Valentin
Date: Mon Nov 17 2014 - 19:36:58 EST


Mikko,

On Tue, Nov 18, 2014 at 02:11:21AM +0200, Mikko Perttunen wrote:

<big cut>

> > diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c
> > index 70f7e9e..893c39c 100644
> > --- a/drivers/thermal/tegra_soctherm.c
> > +++ b/drivers/thermal/tegra_soctherm.c
> > @@ -317,6 +317,10 @@ static int tegra_thermctl_get_temp(void *data, long *out_temp)
> > return 0;
> > }
> >
> > +static const struct thermal_zone_of_device_ops tegra_of_thermal_ops = {
> > + .get_trend = tegra_thermctl_get_temp,
> > +};
>
> This should probably read ".get_temp = tegra_thermctl_get_temp" instead
> of .get_trend :)

Indeed. Sending in v3.

>
> > ...
>
> Cheers,
> Mikko
>

Attachment: signature.asc
Description: Digital signature