Re: [PATCH] staging: lustre: socklnd: sparse warning fix

From: Al Viro
Date: Sun Nov 16 2014 - 12:12:04 EST


> the same value casted the same way few lines below:
> csum = ksocknal_csum(~0, (void *)tx->tx_iov[0].iov_base,
>
> then it seems like a typo in LASSERT() that is got fixed
>
> drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.c
> index 245c9d7..ebd400d 100644
> --- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.c
> +++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.c
> @@ -390,7 +390,7 @@ ksocknal_lib_csum_tx(ksock_tx_t *tx)
> __u32 csum;
> void *base;
>
> - LASSERT(tx->tx_iov[0].iov_base == (void *)&tx->tx_msg);
> + LASSERT((void *)tx->tx_iov[0].iov_base == &tx->tx_msg);

Turn tx_iov into struct kvec * instead.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/