Re: [PATCH net-next] tun: fix issues of iovec iterators using in tun_put_user()

From: Herbert Xu
Date: Thu Nov 13 2014 - 03:58:47 EST


On Thu, Nov 13, 2014 at 04:54:14PM +0800, Jason Wang wrote:
> This patch fixes two issues after using iovec iterators:
> - vlan_offset should be initialized to zero, otherwise unexpected offset
> will be used in skb_copy_datagram_iter()
> - advance iovec iterator when vnet_hdr_sz is greater than sizeof(gso), this
> is the case when mergeable rx buffer were enabled for a virt guest.
>
> Fixes e0b46d0ee9c240c7430a47e9b0365674d4a04522 ("tun: Use iovec iterators")
> Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Jason Wang <jasowang@xxxxxxxxxx>

Good catch.

Acked-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Thanks!
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/