Re: [PATCH V6] UBI: Extend UBI layer debug/messaging capabilities

[Joe Perches]

On Mon, 2014-11-10 at 18:37 +0100, Richard Weinberger wrote:
> Am 03.11.2014 um 14:58 schrieb Tanya Brokhman:
> > If there is more then one UBI device mounted, there is no way to
> > distinguish between messages from different UBI devices.
> > Add device number to all ubi layer message types.

Adding "error" and "warning" to the message logs is
duplicative to the KERN_<LEVEL> logging information.

> > Changes from V5:
> > 	- Added ptr verification @ ubi_err/ubi_msg/ubi_warn
> > 	Removed extra printing of ubi number
> > 	Removed new messages.

Did you all ever look at what I posted?

https://lkml.org/lkml/2014/10/14/280

smaller code, consistent prefixing, consistent with
typical kernel style, etc.

> While testing I noticed that the log output looks quite different.
> 
> e.g.
> [   26.564111] UBI-0: ubi_attach_mtd_dev:default fastmap pool size: 256
> [   26.565438] UBI-0: ubi_attach_mtd_dev:default fastmap WL pool size: 128

If __func__ is really desired, it's generally better to
put a space after the "%s:", __func__ so there's visual
separation between the prefixes and the content.

I agree that emitting function names isn't particularly
useful.

(and Richard, do please remember to trim your posts,
 you sent > 100KB of unnecessary quoted stuff)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/