Re: [PATCH 1/3] ASoC: twl4030: don't report EBUSY if no change requested.

From: Mark Brown
Date: Sat Nov 08 2014 - 04:23:36 EST


On Sat, Nov 08, 2014 at 11:38:03AM +1100, NeilBrown wrote:

> + int val = ucontrol->value.integer.value[0];
> +
> + if (!!(twl4030_read(codec, TWL4030_REG_CODEC_MODE)
> + & TWL4030_OPTION_1) == !!val)
> + /* No change */
> + return 0;

We shouldn't be accepting attempts to set out of range values so there
should be no need for the !! on val (which confused me when I was
reading this).

Attachment: signature.asc
Description: Digital signature