Re: [Linaro-acpi] [RFC PATCH 3/4] arm64, acpi, pci: Add arch specific functions for mmconfig driver.

From: Tomasz Nowicki
Date: Fri Nov 07 2014 - 09:48:00 EST


On 07.11.2014 15:12, Arnd Bergmann wrote:
On Friday 07 November 2014 14:27:55 Tomasz Nowicki wrote:
These calls allow to map/unmap PCI config space ranges (which are specified in
MMCFG ACPI table).

Signed-off-by: Tomasz Nowicki <tomasz.nowicki@xxxxxxxxxx>


Nothing in this patch looks arm64 specific, and most of it looks like a
copy of the x86 code.

Yes, most of the logic was borrowed from mmconfig_64.c file, mmconfig_32.c looks differently, though. It is not simple to merge them both. IMO, we have two choices:
1. Refactor and move mmconfig_64.c out of x86 to e.g. drivers/acpi/ and let it be default.
2. Stay with solution presented in this patch.
3. Thoughts ?

Regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/