Re: [PATCH v2] ASoC: tfa9879: New driver for NXP Semiconductors TFA9879 amplifier.

From: Mark Brown
Date: Fri Nov 07 2014 - 06:18:19 EST


On Thu, Nov 06, 2014 at 05:39:45PM +0100, Peter Rosin wrote:

> + { TFA9879_MISC_STATUS, 0x0000 }, /* 0x15, read-only */

The fix here is the wrong way round - if the device is reporting status
here there should be no default and there should be a volatile operation
(though it's not the end of the world to omit that if it's not used).

Otherwise this looks good.

Attachment: signature.asc
Description: Digital signature